Remove start pages - #1042
Conversation
WalkthroughThis update removes the start page for the "Check" tool by deleting its template and eliminating the route configuration that referenced it. Associated properties in route definitions are adjusted, and a session guard clause is added to the LPA details controller to ensure required data is present before proceeding. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Router
participant CheckTool
User->>Router: Navigate to Check tool from step-by-step page
Router->>CheckTool: Directly enters tool (no start page)
CheckTool-->>User: Presents tool interface
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
💤 Files with no reviewable changes (4)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/controllers/lpaDetailsController.js(1 hunks)src/routes/form-wizard/check/steps.js(0 hunks)src/routes/form-wizard/endpoint-submission-form/steps.js(0 hunks)src/views/check/start.html(0 hunks)src/views/submit/start.html(0 hunks)
💤 Files with no reviewable changes (4)
- src/routes/form-wizard/endpoint-submission-form/steps.js
- src/routes/form-wizard/check/steps.js
- src/views/check/start.html
- src/views/submit/start.html
🧰 Additional context used
🪛 GitHub Check: test
src/controllers/lpaDetailsController.js
[failure] 6-6: test/unit/lpaDetailsController.test.js > lpaDetailsController > locals > should call super.locals
TypeError: Cannot read properties of undefined (reading 'get')
❯ LpaDetailsController.locals src/controllers/lpaDetailsController.js:6:27
❯ test/unit/lpaDetailsController.test.js:63:24
[failure] 6-6: test/unit/lpaDetailsController.test.js > lpaDetailsController > locals > should set localAuthorities options in the form
TypeError: Cannot read properties of undefined (reading 'get')
❯ LpaDetailsController.locals src/controllers/lpaDetailsController.js:6:27
❯ test/unit/lpaDetailsController.test.js:41:24
🪛 GitHub Actions: Unit test coverage report
src/controllers/lpaDetailsController.js
[error] 6-6: TypeError: Cannot read properties of undefined (reading 'get') in LpaDetailsController.locals method during unit tests.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: run-tests / test
🔇 Additional comments (1)
src/controllers/lpaDetailsController.js (1)
10-10: Code looks good.This line appears to be unchanged in functionality - just marked by the diff tool due to the surrounding changes.
f66baa8 to
b69968d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/controllers/lpaDetailsController.js(1 hunks)src/routes/form-wizard/check/steps.js(0 hunks)src/routes/form-wizard/endpoint-submission-form/steps.js(0 hunks)src/views/check/start.html(0 hunks)src/views/submit/start.html(0 hunks)test/unit/lpaDetailsController.test.js(1 hunks)
💤 Files with no reviewable changes (4)
- src/routes/form-wizard/endpoint-submission-form/steps.js
- src/routes/form-wizard/check/steps.js
- src/views/check/start.html
- src/views/submit/start.html
🚧 Files skipped from review as they are similar to previous changes (1)
- src/controllers/lpaDetailsController.js
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: run-tests / test
🔇 Additional comments (1)
test/unit/lpaDetailsController.test.js (1)
28-43: Good refactoring of test setup.The shared
beforeEachblock improves test consistency and reduces code duplication. The mocking setup appropriately reflects the new session dependencies mentioned in the AI summary.
Start pages are no longer used as they have been superseded by deep linking.
b69968d to
b5b018c
Compare
1 participant
What type of PR is this? (check all applicable)
Description
Start pages are no longer used as they have been superseded by deep linking.
Related Tickets & Documents
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit
Bug Fixes
Refactor